-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packageVerificationCodeExcludedFile filename prefix #910
Comments
Because RFC 3986 also has another kind of relative reference that begins with
See "4.2. Relative Reference" in https://datatracker.ietf.org/doc/rfc3986/ Although it is rare, but it may possible to occur. So I think if there will be a validation rule, the rule should allow its occurrence. -- To avoid confusion, we may like to add a small notes on this in the description, in packageVerificationCodeExcludedFile, may be in 3.0.2? |
We're talking about filenames, not URIs. So, there should only be "relative-path" references (to follow the nomenclature of RFC3986). I don't even understand why there is a reference to this RFC. I'd rewrite the whole sentence as simply:
|
Will "absolute-path" with a single slash ( |
I don't think so, since we're talking about which files inside a package should be excluded when computing the verification hash. It makes no sense to use absolute paths for these . But probably @goneall should be the one to decide, since he's more proficient in this SPDXv2 verification stuff. |
Thanks. Would be great if it can be simplified. For reference, the RFC reference is from https://spdx.github.io/spdx-spec/v2.3/package-information/#742-intent . |
Created a PR: #913 |
From /Core/packageVerificationCodeExcludedFile:
"In general, every filename is preceded with a ./, see RFC 3986 ..."
Why use "In general" if the summary clearly states that this is "The relative file name...".
Shouldn't it always preceded with
./
?If that's correct, I'll include a SHACL rule.
The text was updated successfully, but these errors were encountered: