Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mismatched documentation/code for set-dimensions #2

Open
dwmuller opened this issue Oct 13, 2018 · 3 comments
Open

Mismatched documentation/code for set-dimensions #2

dwmuller opened this issue Oct 13, 2018 · 3 comments

Comments

@dwmuller
Copy link

The documentation describes set-dimensions as taking n-rows, then n-cols, but the code actually expects n-cols, then n-rows.

The documented order is consistent with other usages. Unfortunately, fixing the code to match the documentation will be a breaking change.

@spdegabrielle
Copy link
Owner

apologies @dwmuller I only just saw this.

@spdegabrielle
Copy link
Owner

On thinking I think it is better to change the documentation.

@dwmuller
Copy link
Author

Yeah, the inconsistency is unfortunate, but it's probably better not to break existing code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants