Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ThermalBloomingWFE #253

Closed
mperrin opened this issue Aug 27, 2018 · 3 comments
Closed

Implement ThermalBloomingWFE #253

mperrin opened this issue Aug 27, 2018 · 3 comments
Milestone

Comments

@mperrin
Copy link
Collaborator

mperrin commented Aug 27, 2018

Issue by DaPhil
Friday May 18, 2018 at 09:55 GMT
Originally opened as mperrin/poppy#253


I implemented the capability to calculate thermal blooming effects with poppy. For this purpose, I wrote a class PhysicalFresnelWavefront (see #248). I wanted to avoid making another pull request because you guys seem to be quite busy. But have a look at my thermal blooming branch and as sneak peak at the notebook too. I haven't implemented any tests yet but let me know if this is interesting for you.

@mperrin
Copy link
Collaborator Author

mperrin commented Aug 27, 2018

Comment by mperrin
Friday May 18, 2018 at 12:25 GMT


Thanks. Yes, given other commitments and deadlines I probably won’t look at this for a while. Likely not until after the SPIE conference in June.

@mperrin mperrin added this to the Winter 2019 release milestone Aug 12, 2019
@mperrin mperrin modified the milestones: Winter 2019 release, 0.9.2 Jun 19, 2020
@mperrin mperrin removed this from the 1.0.0 milestone Feb 4, 2021
@mperrin mperrin added this to the 1.0.0 milestone Jul 20, 2021
@DaPhil
Copy link
Contributor

DaPhil commented Jul 29, 2021

@mperrin: My pleasure to contribute. I think this issue can now be closed.

@mperrin
Copy link
Collaborator Author

mperrin commented Jul 29, 2021

Added in #438

@mperrin mperrin closed this as completed Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants