-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Imviz: add option for an integrated profile to the aperture photometry plugin #1049
Comments
So given a test data set of
And using the |
Looks about right! 👏 |
Next, throw some |
You can also pass in an evaluated Gaussian2D model data and see if the plot makes sense. |
Before I knew what I was doing I did have some |
When I heard the user request during demo, I wasn't thinking "curve of growth" at all. I was thinking what @javerbukh implemented over at #1097 . Since you already have astropy/photutils#1298 open, "curve of growth" will naturally happen when we use it to tackle #1048 . |
Description
The current aperture photometry plugin shows pixel values. This is sometimes exactly what the user wants, but other times they want the integrated flux profile (sometimes called the "curve of growth"). We should add an option to the aperture photometry plugin to do exactly that - i.e., it would toggle the plot between the current "pixel plot" behavior and an integrated profile.
The idea would be to basically have it plot exactly what the algorithm I describe in #1048 does, but actually plot the profile from steps 1-3 instead of using it to compute the FWHM. That has the convenient feature that the user could look at that plot and immediately see what the FWHM is (i.e., it's where the profile first crosses "half of the max"). Could even add a thin horizontal line at the half-max, although that might make the plot too busy (I leave it to the implementors discretion for the first pass at least).
Additional context
Brought up out-of-band in a discussion with @pontoppi, who may want to comment here if there's more to add than what I have above.
🐱
The text was updated successfully, but these errors were encountered: