Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace proof_of_sql_parser::intermediate_ast::UnaryOp with sqlparser::ast::UnaryOp in the proof-of-sql crate #348

Closed
3 tasks
Tracked by #356
iajoiner opened this issue Nov 7, 2024 · 2 comments
Labels
refactor Code cleanup or reorganization

Comments

@iajoiner
Copy link
Contributor

iajoiner commented Nov 7, 2024

Background and Motivation

This issue is a subtask in #235. In short since we plan to add more SQL features we plan to switch to the sqlparser crate which is a feature-rich, no_std-compatible parser used by DataFusion, which is part of the Arrow ecosystem.

Right now we already have some code that can convert intermediate AST from proof-of-sql-parser we use to sqlparser AST. Now we need to systematically replace instances of proof-of-sql-parser constructs with their corresponding sqlparser ones.

Changes Required

  • Replace proof_of_sql_parser::intermediate_ast::UnaryOp with sqlparser::ast::UnaryOp in the proof-of-sql crate.
  • Make sure no functionality is lost.
  • If necessary add error enum variants for unary ops in sqlparser that we don't support yet.
@Abiji-2020
Copy link
Contributor

I would like to work on this issue.

We need to modify the complete unary operator right? or only the expression involving UnaryOp.

@iajoiner
Copy link
Contributor Author

Closed by #363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Code cleanup or reorganization
Projects
None yet
Development

No branches or pull requests

2 participants