Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce access logs in a binary format #1040

Closed
Keksoj opened this issue Nov 27, 2023 · 1 comment
Closed

Produce access logs in a binary format #1040

Keksoj opened this issue Nov 27, 2023 · 1 comment
Assignees
Milestone

Comments

@Keksoj
Copy link
Contributor

Keksoj commented Nov 27, 2023

For now, access logs are produced by formatting diverse pieces of data, like socket addresses, tags, and so on. std::fmt::Display is implemented for those types, however, calling to_string() on those is CPU-consuming.

It would be beneficiary to produce access logs in a binary format, in order to reduce both formatting time and memory footprint.

Ideally, the binary format would be defined in a protobuf form, like most other types used outside of Sōzu, but this poses the challenge of expressing types like std::net::Socketddr in protobuf.

@Keksoj Keksoj added this to the v0.16.0 milestone Nov 27, 2023
@Keksoj Keksoj self-assigned this Nov 27, 2023
@Keksoj
Copy link
Contributor Author

Keksoj commented Apr 9, 2024

done in #1069

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants