From 9e30892c0451d65cfd6b099d91c93f270761b061 Mon Sep 17 00:00:00 2001 From: Sunny Tyagi <107617248+Tyagi-Sunny@users.noreply.github.com> Date: Mon, 30 Dec 2024 11:41:11 +0530 Subject: [PATCH] fix(all-services): refactor test case of auth service core and notification service (#2230) fix(all-services): resfactor test case of auth service core and notif service resfactor test case of auth service core and notif service 2229 --- .../logger-extension/winston/logger-console.ts | 12 ++++++------ .../__tests__/unit/bearer-verify.provider.unit.ts | 1 + .../unit/process-notification.service.unit.ts | 10 ++++++++++ 3 files changed, 17 insertions(+), 6 deletions(-) diff --git a/packages/core/src/components/logger-extension/winston/logger-console.ts b/packages/core/src/components/logger-extension/winston/logger-console.ts index c3efe44478..815193a016 100644 --- a/packages/core/src/components/logger-extension/winston/logger-console.ts +++ b/packages/core/src/components/logger-extension/winston/logger-console.ts @@ -22,12 +22,12 @@ export class WinstonConsoleLogger extends WinstonLoggerBase { const logFormat = format.combine( format.uncolorize(), format.timestamp(), - format.printf( - (log: LogEntry) => - `[${log.timestamp}] ${log.level} :: ${log.context ?? '-'} :: ${ - log.key - } -> [${log.statusCode ?? '-'}] ${log.message}`, - ), + format.printf((info: TransformableInfo) => { + const log = info as LogEntry; // Type casting + return `[${log.timestamp}] ${log.level} :: ${log.context ?? '-'} :: ${ + log.key + } -> [${log.statusCode ?? '-'}] ${log.message}`; + }), ); this.logger = createLogger({ diff --git a/services/authentication-service/src/__tests__/unit/bearer-verify.provider.unit.ts b/services/authentication-service/src/__tests__/unit/bearer-verify.provider.unit.ts index e9844bcbfb..1a6cf2fd1e 100644 --- a/services/authentication-service/src/__tests__/unit/bearer-verify.provider.unit.ts +++ b/services/authentication-service/src/__tests__/unit/bearer-verify.provider.unit.ts @@ -58,6 +58,7 @@ describe('Bearer Verify Signup Service', () => { } function setUp() { + jwtKeysRepo = sinon.createStubInstance(JwtKeysRepository); // Mock the repository bearerVerifyProvider = new SignupBearerVerifyProvider(jwtKeysRepo, logger); } }); diff --git a/services/notification-service/src/__tests__/unit/process-notification.service.unit.ts b/services/notification-service/src/__tests__/unit/process-notification.service.unit.ts index 31be9df55e..0f9c45e859 100644 --- a/services/notification-service/src/__tests__/unit/process-notification.service.unit.ts +++ b/services/notification-service/src/__tests__/unit/process-notification.service.unit.ts @@ -132,6 +132,16 @@ describe('Process notification Service', () => { function setUp() { notificationRepository = createStubInstance(NotificationRepository); notificationUserRepository = createStubInstance(NotificationUserRepository); + notifProvider = sinon.stub().resolves(); // Mock as a Sinon stub + notifUserService = { + getNotifUsers: sinon.stub().resolves([]), // Mock 'getNotifUsers' to return an empty array + }; + // Mock `filterNotificationSettings` as a stub function + filterNotificationSettings = { + checkUserNotificationSettings: sinon.stub().resolves([]), // Mock with empty array + getNotificationSubscribers: sinon.stub().resolves([]), // Mock with empty array + getDraftSubscribers: sinon.stub().resolves([]), // Mock with empty array + }; processNotificationService = new ProcessNotificationService( notificationRepository, notifProvider,