-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
_transferInvestmentAsset - handle low IA balance #59
Comments
Still don't see the condition in _internalInsufficientLiquiditySwap and _externalLiquidityTrade |
conditions are in functions transferInvestmentAsset (pool2) ,_transferCurrencyAsset (pool1) |
Makes sense for internal swaps. Where is the check for external swaps? |
Got it! Closing issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Scenario:
Insuffient liquidy, CA= IA hence internal transfer to be initiated.
Amount required = 1.5(BaseMin+VarMin)
Amount in IA pool< Amount required
With the current implementation, this case shall throw.
The correct implementation should be to transfer min(amount required,amount in IA pool).
The text was updated successfully, but these errors were encountered: