Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_transferInvestmentAsset - handle low IA balance #59

Closed
nitika-goel opened this issue Dec 25, 2018 · 4 comments
Closed

_transferInvestmentAsset - handle low IA balance #59

nitika-goel opened this issue Dec 25, 2018 · 4 comments
Assignees

Comments

@nitika-goel
Copy link
Contributor

Scenario:
Insuffient liquidy, CA= IA hence internal transfer to be initiated.
Amount required = 1.5(BaseMin+VarMin)
Amount in IA pool< Amount required
With the current implementation, this case shall throw.

The correct implementation should be to transfer min(amount required,amount in IA pool).

@tech-somish tech-somish self-assigned this Mar 15, 2019
@tech-somish tech-somish added the resolved - pending closure Issues resolved but pending closure via issue reporter label Mar 15, 2019
@nitika-goel
Copy link
Contributor Author

Still don't see the condition in _internalInsufficientLiquiditySwap and _externalLiquidityTrade

@nitika-goel nitika-goel removed the resolved - pending closure Issues resolved but pending closure via issue reporter label Mar 22, 2019
@tech-somish
Copy link
Collaborator

conditions are in functions transferInvestmentAsset (pool2) ,_transferCurrencyAsset (pool1)
check and close the issue

@nitika-goel
Copy link
Contributor Author

Makes sense for internal swaps. Where is the check for external swaps?

@nitika-goel
Copy link
Contributor Author

Got it! Closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants