Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removeDelegation function is incomplete #56

Closed
nervehammer opened this issue Dec 25, 2018 · 2 comments
Closed

removeDelegation function is incomplete #56

nervehammer opened this issue Dec 25, 2018 · 2 comments
Assignees
@tech-somish

Comments

@nervehammer
Copy link
Contributor

removeDelegation is incomplete as it does not deal with the mapping followerDelegation and leaderDelegation
@nervehammer nervehammer mentioned this issue Dec 25, 2018
Closed
@tech-somish
Copy link
Collaborator

Yeah during Undelegation we are not changing followerDelegation and leaderDelegation but Whenever we are using followerDelegation and leaderDelegation ,there is one check from structure DelegateVote which will ensure the correct leader of user.
check and reply if any further doubts.
@nervehammer

@nitika-goel
Copy link
Contributor

Looks fine to me. Closing issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tech-somish tech-somish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nervehammer @nitika-goel @tech-somish