Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Governance ClaimReward Exploit #55

Closed
nervehammer opened this issue Dec 25, 2018 · 2 comments
Closed

Governance ClaimReward Exploit #55

nervehammer opened this issue Dec 25, 2018 · 2 comments
Assignees
@nitika-goel @tech-somish

Comments

@nervehammer
Copy link
Contributor

claimReward function if not delegated, doesn't checks if the voter has cast a vote or not.

If there is no delegation leader = _memberAddress and the if statement if (allVotes[voteId].dateAdd > (lastUpd + tokenHoldingTime) || leader == _memberAddress) will always return true.

Consequences :-

  1. Any member if not delegated can claim the reward no matter if voted or not.
  2. The pool will eventually drain as reward distribution exceeds the actual reward to be given.
@nervehammer nervehammer pinned this issue Dec 25, 2018
@tech-somish
Copy link
Collaborator

Done with changes.
check and confirm.
@nervehammer

@tech-somish tech-somish added the resolved - pending closure Issues resolved but pending closure via issue reporter label Dec 27, 2018
@nervehammer nervehammer unpinned this issue Dec 31, 2018
@nitika-goel nitika-goel removed bug resolved - pending closure Issues resolved but pending closure via issue reporter labels Mar 22, 2019
@nitika-goel
Copy link
Contributor

Changes look good. Closing issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nitika-goel nitika-goel

@tech-somish tech-somish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nervehammer @nitika-goel @tech-somish