Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V(TP) = CA Balance(in ETH) + IA BAlance(in ETH) #53

Closed
nitika-goel opened this issue Dec 24, 2018 · 1 comment
Closed

V(TP) = CA Balance(in ETH) + IA BAlance(in ETH) #53

nitika-goel opened this issue Dec 24, 2018 · 1 comment
Assignees
@tech-somish

Comments

@nitika-goel
Copy link
Contributor

If I understand correctly, we have only included CA balance in V(TP). We actually need to include both. This also removes the need to calculate _totalRiskPoolBalance separately.

However, V(TP) is based on currrent price and we are not saving currency rates for all assets. Hence, need to figure out the best way here.

Feedback appreciated.
@nervehammer nervehammer pinned this issue Dec 31, 2018
@tech-somish tech-somish self-assigned this Mar 15, 2019
@tech-somish tech-somish added the resolved - pending closure Issues resolved but pending closure via issue reporter label Mar 15, 2019
@nitika-goel
Copy link
Contributor Author

Issue has been resolved. Thanks

@nitika-goel nitika-goel removed the resolved - pending closure Issues resolved but pending closure via issue reporter label Mar 22, 2019
@tech-somish tech-somish unpinned this issue Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tech-somish tech-somish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nitika-goel @tech-somish