Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start all internal functions with _ #52

Closed
nitika-goel opened this issue Dec 24, 2018 · 2 comments
Closed

Start all internal functions with _ #52

nitika-goel opened this issue Dec 24, 2018 · 2 comments
Assignees
@tech-somish

Comments

@nitika-goel
Copy link
Contributor

We should maintain a naming convention and start all internal functions with _. For ex reanme calculateIARank to _calculateIARank
@tech-somish tech-somish added the resolved - pending closure Issues resolved but pending closure via issue reporter label Mar 15, 2019
@nitika-goel
Copy link
Contributor Author

Changes made except function addRewardIncentive in ClaimsData.sol

@nitika-goel nitika-goel removed enhancement resolved - pending closure Issues resolved but pending closure via issue reporter labels Mar 22, 2019
@tech-somish tech-somish added the resolved - pending closure Issues resolved but pending closure via issue reporter label Mar 23, 2019
@nitika-goel
Copy link
Contributor Author

Changes look fine. Closing issue.

@nitika-goel nitika-goel removed the resolved - pending closure Issues resolved but pending closure via issue reporter label Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tech-somish tech-somish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nervehammer @nitika-goel @tech-somish