Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes in internalExcessLiquiditySwap #51

Closed
nitika-goel opened this issue Dec 24, 2018 · 2 comments
Closed

Changes in internalExcessLiquiditySwap #51

nitika-goel opened this issue Dec 24, 2018 · 2 comments
Assignees
@nervehammer

Comments

@nitika-goel
Copy link
Contributor

  1. Rename to _ExcessLiquiditySwap in line with the naming convention we are following(all internal functions start with _)
  2. Reuse baseMin,varMin in the internal function as we have fetched the same in the external function.
@nervehammer
Copy link
Contributor

done required changes, please refer 41196fc

@nervehammer nervehammer self-assigned this Dec 27, 2018
@nervehammer nervehammer added the resolved - pending closure Issues resolved but pending closure via issue reporter label Dec 27, 2018
@nitika-goel
Copy link
Contributor Author

Changes have been made. Closing issue!

@nitika-goel nitika-goel removed the resolved - pending closure Issues resolved but pending closure via issue reporter label Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nervehammer nervehammer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nervehammer @nitika-goel