Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes delegateCallBack #50

Closed
nitika-goel opened this issue Dec 24, 2018 · 4 comments
Closed

Changes delegateCallBack #50

nitika-goel opened this issue Dec 24, 2018 · 4 comments
Assignees
@nervehammer

Comments

@nitika-goel
Copy link
Contributor

  • Call pd.updateDateUpdOfAPI(myid); once, instead of each if statement
  • Use checkPause instead of if (ms.isPause() == false)
  • Fetch pd.getApiIdTypeOf(myid) once instead of calling it repeatedly in each if condition
@nervehammer
Copy link
Contributor

nervehammer commented Dec 24, 2018 •
edited
Loading

@nitika-goel the second point cannot be done if we use a checkPause modifier as if the system is in the Emergency Pause state, the oraclize call for removing emergency pause will simply throw

@nitika-goel
Copy link
Contributor Author

Ah ok! Makes sense! Let's skip the 2nd one.

@nervehammer nervehammer self-assigned this Dec 25, 2018
@nervehammer
Copy link
Contributor

done, please refer 41196fc

@nervehammer nervehammer added resolved - pending closure Issues resolved but pending closure via issue reporter and removed enhancement labels Dec 27, 2018
@nitika-goel
Copy link
Contributor Author

Further changes in f6109b7
Closing issue

@nitika-goel nitika-goel removed the resolved - pending closure Issues resolved but pending closure via issue reporter label Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nervehammer nervehammer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nervehammer @nitika-goel