Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NXMaster2 contract #48

Closed
nervehammer opened this issue Dec 10, 2018 · 5 comments
Closed

Remove NXMaster2 contract #48

nervehammer opened this issue Dec 10, 2018 · 5 comments
Assignees
@tech-somish
Labels
enhancement resolved - pending closure Issues resolved but pending closure via issue reporter

Comments

@nervehammer
Copy link
Contributor

nervehammer commented Dec 10, 2018 •
edited
Loading

I think we don't need NXMaster2 contract as right now it just pushes some values to data contracts and doesn't have any other functionality (it acts just like an use and throw contract).
We can push data directly via individual data contract's constructor. This will save us a lot deployment gas and makes deployment process more streamlined.
@nervehammer
Copy link
Contributor Author

please have a look @nitika-goel

@nitika-goel
Copy link
Contributor

nitika-goel commented Dec 10, 2018 •
edited
Loading

Looks good @nervehammer. Let's make the required changes.

@tech-somish
Copy link
Collaborator

changes updated in git, check and ping if any issue.
commit number :-- 2e5e977

@tech-somish tech-somish added the resolved - pending closure Issues resolved but pending closure via issue reporter label Dec 10, 2018
@nervehammer
Copy link
Contributor Author

nervehammer commented Dec 10, 2018 •
edited
Loading

looks good @tech-somish

@nervehammer
Copy link
Contributor Author

@nitika-goel this saves us nearly 1.8m gas during deployment 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tech-somish tech-somish

Labels
enhancement resolved - pending closure Issues resolved but pending closure via issue reporter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nervehammer @nitika-goel @tech-somish