Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create enums for claim status #47

Closed
nervehammer opened this issue Dec 10, 2018 · 3 comments
Closed

Create enums for claim status #47

nervehammer opened this issue Dec 10, 2018 · 3 comments
Assignees
@tech-somish
Labels
enhancement resolved - pending closure Issues resolved but pending closure via issue reporter

Comments

@nervehammer
Copy link
Contributor

We should create enum for claim status too, as function addStatusInClaims() of NXMaster2 takes so much gas when called.
@tech-somish tech-somish self-assigned this Dec 10, 2018
@nervehammer
Copy link
Contributor Author

or we can remove whole status description, as it is not required by smart contract.

@tech-somish
Copy link
Collaborator

Yeah! no need to create separate enum for description.Just need to remove description from claim reward structure.
changes updated in git, check and ping if any issue.
commit number :-- 2e5e977

@tech-somish tech-somish added the resolved - pending closure Issues resolved but pending closure via issue reporter label Dec 10, 2018
@nervehammer
Copy link
Contributor Author

looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tech-somish tech-somish

Labels
enhancement resolved - pending closure Issues resolved but pending closure via issue reporter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nervehammer @tech-somish