Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notarise address for KYCTrigger #43

Closed
nitika-goel opened this issue Dec 5, 2018 · 2 comments
Closed

Add notarise address for KYCTrigger #43

nitika-goel opened this issue Dec 5, 2018 · 2 comments
Assignees

Comments

@nitika-goel
Copy link
Contributor

KYC shall be triggered by a specific address only. Hence create a notarise address and check for the same. I understand that this is currently done to allow any user Pass/Fail KYC in the test demo. However, a pass/fail request should be passed on to an API, who should then trigger the function. Once, integration with Identityminds is complete, the Identitymind API would hit this API post their verification result.

@tech-somish tech-somish self-assigned this Dec 6, 2018
@tech-somish tech-somish added the resolved - pending closure Issues resolved but pending closure via issue reporter label Mar 15, 2019
@nitika-goel
Copy link
Contributor Author

In function kycTrigger in Quotation.sol, the check is there only if verdict is true. The check for msg.sender==kycAuthAddress should be there irrespective of verdict.

@nitika-goel nitika-goel removed enhancement resolved - pending closure Issues resolved but pending closure via issue reporter labels Mar 22, 2019
@tech-somish tech-somish added the resolved - pending closure Issues resolved but pending closure via issue reporter label Mar 23, 2019
@nitika-goel
Copy link
Contributor Author

Changes look good. Closing issue.

@nitika-goel nitika-goel removed the resolved - pending closure Issues resolved but pending closure via issue reporter label Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants