Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create enums for cover status #41

Closed
nitika-goel opened this issue Dec 5, 2018 · 3 comments
Closed

Create enums for cover status #41

nitika-goel opened this issue Dec 5, 2018 · 3 comments
Assignees
@tech-somish

Comments

@nitika-goel
Copy link
Contributor

As requested in the last audit report, we should create enum for cover status and use these instead of status numbers. eg enum CoverStatus {Active, ClaimAccepted, ClaimDenied, CoverExpired, ClaimSubmitted, Requested }; and then use them like qd.getCoverStatusNo(_cid) != uint(CoverStatus .CoverExpired) instead of qd.getCoverStatusNo(_cid) != 3
@nitika-goel nitika-goel mentioned this issue Dec 5, 2018
Closed
@nitika-goel nitika-goel changed the title Creater enums for cover status Create enums for cover status Dec 5, 2018
@tech-somish tech-somish self-assigned this Dec 7, 2018
@tech-somish tech-somish added resolved - pending closure Issues resolved but pending closure via issue reporter and removed resolved - pending closure Issues resolved but pending closure via issue reporter labels Dec 7, 2018
@tech-somish
Copy link
Collaborator

changes updated in git, check if any issue.
commit number :-- dc38e63

@tech-somish tech-somish added resolved - pending closure Issues resolved but pending closure via issue reporter enhancement labels Dec 10, 2018
@nitika-goel
Copy link
Contributor Author

Changes still pending in functions like expireCover. Please recheck.

@nitika-goel nitika-goel removed enhancement resolved - pending closure Issues resolved but pending closure via issue reporter labels Dec 24, 2018
@tech-somish tech-somish added the resolved - pending closure Issues resolved but pending closure via issue reporter label Mar 15, 2019
@nitika-goel
Copy link
Contributor Author

Changes have been made. Thanks!

@nitika-goel nitika-goel removed the resolved - pending closure Issues resolved but pending closure via issue reporter label Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tech-somish tech-somish

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nitika-goel @tech-somish