[GraphQL]: Optimize cache-key function

[buffalojoec]

Problem

Since fast-stable-stringify doesn't support bigint natively, we've had to use json-stable-stringify in the GraphQL library.

However, json-stable-stringify, is huge, and we shouldn't introduce this bloat to the codebase.

Proposed Solution

We can do one of three things:

1. Find a very lightweight cache-key function library that supports bigint.
2. Fork fast-stable-stringify and add bigint support.
3. PR bigint support into fast-stable-stringify.

[Hrushi20]

Hey! I'm interested in working on this issue. Do I replace json-stable-stringify with fast-stable-stringify in package.json file and update the code usage?

[buffalojoec]

Hey! I'm interested in working on this issue. Do I replace json-stable-stringify with fast-stable-stringify in package.json file and update the code usage?

Hey, I've added some more context to the issue! Let me know if you still have questions.

[Hrushi20]

What is the definition of cache-key function? Also I see that stringify in json-stable-stringify converts the object into JSONString.

[Hrushi20]

We can try option 3, fast-stable-stringify has not been updated since 7years. Not sure if the project is active. We can fallback to option 2 as our next option.

[Hrushi20]

json-stringify-deterministic also looks like a very good option. There is more than 50% reduction in size of dependency. We need to replace json-stable-stringify in package.json and continue to use the same replacer function in loader.ts file

Name	Unpacked Size
json-stable-stringify	27.7 kB
json-stringify-deterministic	11.6 kB

[buffalojoec]

Yeah that's not bad. I'm a bit biased, though because fast-stable-stringify is < 1 kB minified.
https://bundlephobia.com/package/[email protected]

I think if we forked it into our monorepo here and just added bigint support we could still capture ~1 kB minified size, which is awesome, especially for anywhere else we use it.

What do you think of going the fork route? @solana/fast-stable-stringify?

[Hrushi20]

Sounds good to me. I'm working on it.

[Hrushi20]

Can the forked package be in javascript?

[Hrushi20]

I've forked and updated the package to support BigInt. I've also added some tests to ensure correct behavior.

[buffalojoec]

Can the forked package be in javascript?

Yes!

I've forked and updated the package to support BigInt. I've also added some tests to ensure correct behavior.

Are you planning to open a pull request to add it to this monorepo? That would be the ideal place for us!

[Hrushi20]

Can the forked package be in javascript?

Yes!

I've forked and updated the package to support BigInt. I've also added some tests to ensure correct behavior.

Are you planning to open a pull request to add it to this monorepo? That would be the ideal place for us!

Working on adding it to monorepo.

[github-actions]

Because there has been no activity on this issue for 7 days since it was closed, it has been automatically locked. Please open a new issue if it requires a follow up.