Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for type constraints on suggest #4

Open
zang0 opened this issue Jul 8, 2016 · 1 comment
Open

Add support for type constraints on suggest #4

zang0 opened this issue Jul 8, 2016 · 1 comment
Assignees

Comments

@zang0
Copy link
Contributor

zang0 commented Jul 8, 2016

When we add entities beyond regions, like diseases, etc, we'll probably want to constrain by type as well, something like:

http://odn-backend.herokuapp.com/suggest/v1/entity?query=seat&limit=10&type=region

for now I think its not pressing so feel free to punt if its more than a few minutes to impl.

@zang0 zang0 added this to the V1 milestone Jul 8, 2016
@aaasen
Copy link
Contributor

aaasen commented Jul 8, 2016

There isn't a way to do this using the Socrata autosuggest API, so I would have to either make a separate autocomplete dataset for each region type or pull down results from the main entity autosuggest dataset and then filter them. Neither solution seems optimal so I'm going to punt on this one.

@zang0 zang0 modified the milestones: V2, V1 Jul 9, 2016
@zang0 zang0 modified the milestones: V3, V2, V4 Sep 12, 2016
@zang0 zang0 removed this from the V4 milestone Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants