Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin Tool Feature]: Phone value as string instead of number #719

Open
2 tasks done
ssandino opened this issue Jan 26, 2024 · 1 comment
Open
2 tasks done

[Admin Tool Feature]: Phone value as string instead of number #719

ssandino opened this issue Jan 26, 2024 · 1 comment
Labels
admin tool Issues concerning Admin Tool

Comments

@ssandino
Copy link
Member

Is there an existing request for this feature?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe.

Proposition by @mkue in a merged PR #706 :

I think we should switch to using a string to store a phone number using the + prefix. The validity of the phone number could then easily be checked with a regex.

@MDikkii @novas1r1, can you assess the impact of such a change on the mobile app? Are there any best practices in mobile development that should be considered?

Describe the solution/feature

No response

Describe alternatives you've considered

No response

Criteria for Completion

No response

Anything else?

No response

Code of Conduct

  • I've read the Code of Conduct and understand my responsibilities as a member of the Social Income community
@mkue
Copy link
Contributor

mkue commented Jan 22, 2025

Use libphonenumber for serialization and de-serialization.

Communicate with mobile app team before deploying the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin tool Issues concerning Admin Tool
Projects
None yet
Development

No branches or pull requests

2 participants