You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Our implementation of the R(2+1)D model outputs tensors of different shapes, depending on the start_index and end_index model parameters given at class instantiation. However, the output_shape() method of R2P1DRunner is set to always return (10, 400), which is the output of the final layer in R(2+1)D. In fact, this is an artifact from #58, in which we made output_shape() a static method; the method cannot access internal attributes like self.start_index and self.end_index to return the correct output shape. We need to change the implementation so that output_shape() can return different values according to model parameters.
One possible way to do this would be to retrieve model parameters from the input pipeline configuration and pass the parameters to output_shape(), similar to what we are doing in benchmark.py:
forstep_idx, stepinenumerate(pipeline):
...
process_runner=Process(target=runner, args=...,
kwargs=step) # <-- right here
This way, we can let the output_shape() method determine which shape to return based on model parameters, while still keeping output_shape() as a static method.
The text was updated successfully, but these errors were encountered:
Our implementation of the R(2+1)D model outputs tensors of different shapes, depending on the start_index and end_index model parameters given at class instantiation. However, the
output_shape()
method ofR2P1DRunner
is set to always return (10, 400), which is the output of the final layer in R(2+1)D. In fact, this is an artifact from #58, in which we madeoutput_shape()
a static method; the method cannot access internal attributes likeself.start_index
andself.end_index
to return the correct output shape. We need to change the implementation so thatoutput_shape()
can return different values according to model parameters.One possible way to do this would be to retrieve model parameters from the input pipeline configuration and pass the parameters to
output_shape()
, similar to what we are doing inbenchmark.py
:This way, we can let the
output_shape()
method determine which shape to return based on model parameters, while still keepingoutput_shape()
as a static method.The text was updated successfully, but these errors were encountered: