Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedding parameter placement in NMT model #2

Open
sj6077 opened this issue Jul 25, 2018 · 0 comments
Open

Embedding parameter placement in NMT model #2

sj6077 opened this issue Jul 25, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@sj6077
Copy link
Contributor

sj6077 commented Jul 25, 2018

Things to Change

According to NMT, embedding parameter goes to a worker if the number of embedding partitions is one. It happens in the Parallax, too.

Current Behavior

PS fails when the number of embedding partitions is one.

Expected Behavior

Work well regardless of the number of embedding partitions.

Failure Information (for bugs)

Failure Logs

How to Reproduce

Run NMT example with "num_embedding_partitions=1"

Related Issues
@sj6077 sj6077 added the bug Something isn't working label Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sj6077