Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many files for one algorithm #55

Open
jsjason opened this issue Jun 23, 2015 · 3 comments
Open

Too many files for one algorithm #55

jsjason opened this issue Jun 23, 2015 · 3 comments
Labels

Comments

@jsjason
Copy link
Contributor

jsjason commented Jun 23, 2015

Currently, a user needs to create many files (sometimes more than 10) to implement a single example using Dolphin. Although #7 solves this partially, #7 will not be resolved for a while. It'd be better if we can reduce the number of new files a user needs to code without the help of a DSL.

@kijungs
Copy link
Contributor

kijungs commented Jun 23, 2015

Too many files also have bothered me. I think we can reduce the numbers by using inner classes.
For example, it seems that ClusteringPreCommGroup and KMeansMainCommGroup do not need to be a separate file.

@dongjoon-hyun
Copy link
Contributor

Hi, all.
For this issue, is it possible to provide a single-file example?

@jsjason
Copy link
Contributor Author

jsjason commented Aug 3, 2015

Hi, I guess we could pack the classes together to reduce the number of files, but I'm not sure about using only a single file. We would have to pack CtrlTask, CompTask, StageInfo, the Launcher class (e.g. PageRankREEF), and the parameter classes together in one file, and that would be pretty ugly. I think we should consider abstracting the interfaces a bit more, than trying to implement an example that uses only one file.

@jsjason jsjason added the BSP label Sep 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants