Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the unittest without any error #145

Open
BECATRUE opened this issue Sep 15, 2023 · 4 comments
Open

Pass the unittest without any error #145

BECATRUE opened this issue Sep 15, 2023 · 4 comments
Assignees
@BECATRUE
Labels
test About testing

Comments

@BECATRUE
Copy link
Member

Feature you want to implement

After updating QIWIS version, it causes too many unittest error due to global constants.
Thus, I will resolve this temporarily, not completely. (Just make the unittest passed)
@BECATRUE BECATRUE added the test About testing label Sep 15, 2023
@BECATRUE BECATRUE self-assigned this Sep 15, 2023
@kangz12345
Copy link
Member

If it is a temporal fix, please do not close this issue until we resolve this completely.

BECATRUE added a commit that referenced this issue Sep 15, 2023
@BECATRUE
Define the global constants
d888810 
See also: #145
BECATRUE added a commit that referenced this issue Sep 15, 2023
@BECATRUE
Set constants in test_explorer.py
1e09f6a 
See also: #145
BECATRUE added a commit that referenced this issue Sep 15, 2023
@BECATRUE
Pass IP and PORT to thread
16670e0 
See also: #145
BECATRUE added a commit that referenced this issue Sep 15, 2023
@BECATRUE
Fix test_open_builder()
e2e8f1a 
See also: #145
BECATRUE added a commit that referenced this issue Sep 15, 2023
@BECATRUE
Fix test_open_experiment()
899c612 
See also: #145
@BECATRUE
Copy link
Member Author

BECATRUE commented Sep 15, 2023 •
edited
Loading

@kangz12345 Could you check this branch?

First, I fixed only test_explorer.py to use global constants!
If you think it is okay, I will apply the same method to other apps.

@kangz12345
Copy link
Member

I think instead of assigning the constants namespace like

explorer.ExplorerApp._constants = CONSTANTS

mocking it in setUp() would be better.

patcher = mock.patch("explorer.ExplorerApp._constants", CONSTANTS)

@BECATRUE
Copy link
Member Author

Okay! Then, I will apply your suggestion.

BECATRUE added a commit that referenced this issue Sep 15, 2023
@BECATRUE
Mock the constants in test_explorer.py
b1dcfe1 
See also: #145
BECATRUE added a commit that referenced this issue Sep 15, 2023
@BECATRUE
Apply global constants in test_builder.py
db902ca 
See also: #145
BECATRUE added a commit that referenced this issue Sep 15, 2023
@BECATRUE
Apply global constants in test_scheduler.py
68d0766 
See also: #145
@BECATRUE BECATRUE mentioned this issue Sep 15, 2023
Merged
BECATRUE added a commit that referenced this issue Sep 16, 2023
@BECATRUE
Pass the unittest without any error (#147)
9acfaaf 
I added a patcher to mock the `_constants` of each app.

This is related to #145.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BECATRUE BECATRUE

Labels
test About testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kangz12345 @BECATRUE