Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1868288: Downgrade cursor.py log level from info to debug #2126

Open
afranzi opened this issue Dec 24, 2024 · 2 comments · Fixed by #2127
Open

SNOW-1868288: Downgrade cursor.py log level from info to debug #2126

afranzi opened this issue Dec 24, 2024 · 2 comments · Fixed by #2127
Assignees
@sfc-gh-dszmolka
Labels
feature status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. status-triage_done Initial triage done, will be further handled by the driver team

Comments

@afranzi
Copy link

afranzi commented Dec 24, 2024

What is the current behavior?

The cursor has a log.info which becomes quite noisy when executing dbt-snowflake + it doesn't provide any value at all.
It would be great if we could downgrade the log level from info to debug to reduce noise.
https://github.com/snowflakedb/snowflake-connector-python/blob/main/src/snowflake/connector/cursor.py#L1168

What is the desired behavior?

Downgrade the log level from info to debug to reduce noise in cursor.py

        if not (is_dml or self.is_file_transfer):
            logger.debug(
                "Number of results in first chunk: %s", result_chunks[0].rowcount
            )

How would this improve snowflake-connector-python?

Reduce log noise

References and other background

No response
@sfc-gh-dszmolka sfc-gh-dszmolka self-assigned this Dec 24, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka added status-triage_done Initial triage done, will be further handled by the driver team and removed needs triage labels Dec 24, 2024
@sfc-gh-dszmolka sfc-gh-dszmolka mentioned this issue Dec 24, 2024
Merged
7 tasks
@sfc-gh-dszmolka sfc-gh-dszmolka added the status-pr_pending_merge A PR is made and is under review label Dec 24, 2024
@sfc-gh-dszmolka
Copy link
Contributor

hi - thanks for raising this. created #2127, the team will review . Will keep this thread posted.

@sfc-gh-dszmolka sfc-gh-dszmolka changed the title Downgrade cursor.py log level from info to debug SNOW-1868288: Downgrade cursor.py log level from info to debug Dec 24, 2024
@sfc-gh-mkeller sfc-gh-mkeller linked a pull request Jan 2, 2025 that will close this issue
SNOW-1868288 log level to debug in chunk rowcount logging #2127
Merged
7 tasks
@sfc-gh-dszmolka sfc-gh-dszmolka added status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. and removed status-pr_pending_merge A PR is made and is under review labels Jan 3, 2025
@sfc-gh-dszmolka
Copy link
Contributor

PR merged and awaiting next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfc-gh-dszmolka sfc-gh-dszmolka

Labels
feature status-fixed_awaiting_release The issue has been fixed, its PR merged, and now awaiting the next release cycle of the connector. status-triage_done Initial triage done, will be further handled by the driver team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SNOW-1868288 log level to debug in chunk rowcount logging snowflakedb/snowflake-connector-python
3 participants
@afranzi @sfc-gh-mkeller @sfc-gh-dszmolka