Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-994431: Pyarrow Table has wrong type signature in cursor.py #1834

Closed
thomasaarholt opened this issue Dec 19, 2023 · 0 comments · Fixed by #1835
Closed

SNOW-994431: Pyarrow Table has wrong type signature in cursor.py #1834

thomasaarholt opened this issue Dec 19, 2023 · 0 comments · Fixed by #1835

Comments

@thomasaarholt
Copy link
Contributor

thomasaarholt commented Dec 19, 2023 •
edited
Loading

In cursor.py, pyarrow's Table is set as Table = None when pyarrow is not available. It is then used as a type hint. You can't use expressions as type hints, and the correct way here (especially since Table isn't used anywhere in the file except as a type hint) is to use if TYPE_CHECKING.

I have made a PR for this, see link below shortly.
@github-actions github-actions bot changed the title Pyarrow Table has wrong type signature in cursor.py SNOW-994431: Pyarrow Table has wrong type signature in cursor.py Dec 19, 2023
@thomasaarholt thomasaarholt mentioned this issue Dec 19, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix pyarrow Table type hinting in cursor.py thomasaarholt/snowflake-connector-python
1 participant
@thomasaarholt