Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: no setting to disable "minimize to system tray" #153

Closed
musalbas opened this issue Aug 20, 2023 · 3 comments · Fixed by #200
Closed

[Bug]: no setting to disable "minimize to system tray" #153

musalbas opened this issue Aug 20, 2023 · 3 comments · Fixed by #200
Labels
bug Something isn't working

Comments

@musalbas
Copy link

What happened?

On first run, when I close Signal, a notification pops up that claims that minimize to system tray can be disabled in the settings. However, that option doesn't exist.

Maybe isSystemTraySupported is false in https://github.com/signalapp/Signal-Desktop/blob/620e85ca01d8edfcf7f72ec93b256613b0ddde96/ts/components/Preferences.tsx#L432?

What should have happened?

There should be a setting to disable "minimize to system tray" in preferences.

Output of snap info $snap_name

name:      signal-desktop
summary:   Speak Freely - Private Messenger
publisher: Snapcrafters✪
store-url: https://snapcraft.io/signal-desktop
contact:   https://github.com//snapcrafters/signal-desktop/issues
license:   AGPL-3.0-only
description: |
  **Note: To use the Signal desktop app, you must first install Signal on your phone.**
  
  Millions of people use Signal every day for free and instantaneous communication anywhere in the
  world. Send and receive high-fidelity messages, participate in HD voice/video calls, and explore a
  growing set of new features that help you stay connected. Signal's advanced privacy-preserving
  technology is always enabled, so you can focus on sharing the moments that matter with the people
  who matter to you.
  
  - Say anything - State-of-the-art end-to-end encryption (powered by the open source Signal
  Protocol™) keeps your conversations secure. Privacy isn't an optional mode; it's just the way that
  Signal works. Every message, every call, every time.
  - Go fast - Messages are delivered quickly and reliably, even on slow networks. Signal is
  optimized to operate in the most constrained environment possible.
  - Feel free - Signal is a completely independent 501c3 nonprofit. Development is supported by
  users like you. No advertisements. No trackers. No kidding.
  - Be yourself - You can use your existing phone number and address book to securely communicate
  with your friends.
  - Speak up - Whether they live across town or across the ocean, Signal's enhanced audio and video
  quality will make your friends and family feel closer.
  - Whisper in the shadows - Switch to the dark theme if you refuse to see the light.
  
  **Are you having issues?**
  
  Let us know by creating a new issue here: https://github.com/snapcrafters/signal-desktop/issues
  
  **Authors**
  
  This snap is maintained by the Snapcrafters community, and is not necessarily endorsed or
  officially maintained by the upstream developers.
commands:
  - signal-desktop
snap-id:      r4LxMVp7zWramXsJQAKdamxy6TAWlaDD
tracking:     latest/stable
refresh-date: today at 17:53 BST
channels:
  latest/stable:    6.27.1 2023-08-08 (510) 181MB -
  latest/candidate: 6.28.0 2023-08-09 (512) 182MB -
  latest/beta:      ↑                             
  latest/edge:      ↑                             
installed:          6.27.1            (510) 181MB -

Output of snap connections $snap_name

Interface               Plug                                   Slot                            Notes
audio-playback          signal-desktop:audio-playback          :audio-playback                 -
audio-record            signal-desktop:audio-record            :audio-record                   -
browser-support         signal-desktop:browser-support         :browser-support                -
camera                  signal-desktop:camera                  :camera                         -
content[gnome-42-2204]  signal-desktop:gnome-42-2204           gnome-42-2204:gnome-42-2204     -
content[gtk-3-themes]   signal-desktop:gtk-3-themes            gtk-common-themes:gtk-3-themes  -
content[icon-themes]    signal-desktop:icon-themes             gtk-common-themes:icon-themes   -
content[sound-themes]   signal-desktop:sound-themes            gtk-common-themes:sound-themes  -
desktop                 signal-desktop:desktop                 :desktop                        -
desktop-legacy          signal-desktop:desktop-legacy          :desktop-legacy                 -
gsettings               signal-desktop:gsettings               :gsettings                      -
home                    signal-desktop:home                    :home                           -
network                 signal-desktop:network                 :network                        -
opengl                  signal-desktop:opengl                  :opengl                         -
removable-media         signal-desktop:removable-media         -                               -
screen-inhibit-control  signal-desktop:screen-inhibit-control  :screen-inhibit-control         -
unity7                  signal-desktop:unity7                  :unity7                         -
wayland                 signal-desktop:wayland                 :wayland                        -
x11                     signal-desktop:x11                     :x11                            -

Output of snap version

snap    2.59.5
snapd   2.59.5
series  16
ubuntu  23.04
kernel  6.2.0-27-generic

Relevant log output

No response

Teminal output of app

No response

@musalbas musalbas added the bug Something isn't working label Aug 20, 2023
@merlijn-sebrechts
Copy link
Member

Thanks for reporting this! There isn't much we can do about that since this is an upstream bug of the signal desktop app itself. Can you report it there? https://github.com/signalapp/Signal-Desktop/issues

This bugtracker is only for issues specific to the snap. So if it's not working either in the native signal app, then we can't help you.

See: https://github.com/signalapp/Signal-Desktop/blob/824d2524bc55c1a3b2e3c140a051fe60ba6b6baf/ts/types/Settings.ts#L37C45-L37C45

@musalbas
Copy link
Author

musalbas commented Nov 15, 2023

Hi @merlijn-sebrechts, fwiw this bug isn't as big of a deal for users that don't want the tray icon on the official deb package version of Signal, just this snap. This is because in this snap, Signal is ran with --use-tray-icon, an experimental flag that is not enabled by default on the official deb package.

command: opt/Signal/signal-desktop --use-tray-icon --no-sandbox

@merlijn-sebrechts
Copy link
Member

Indeed, you're right, my bad!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants