Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for text alignment #49

Open
bertfrees opened this issue Aug 17, 2015 · 8 comments
Open

Tests for text alignment #49

bertfrees opened this issue Aug 17, 2015 · 8 comments

Comments

@bertfrees
Copy link
Member

@snaekobbi/experts If text is to be centered and the difference between the width of a line of text and the full block width is an odd number, there are two options for positioning the line of text. Either somewhat more to the left or somewhat more to the right. In this example from Mischa for white space handling, you can see that the text on the third row is positioned somewhat more to the left. Is this the preferred behavior for everyone?

@stesk
Copy link

stesk commented Aug 18, 2015

Placing it to the left is probably best, yes.

@KariRudjord
Copy link

To the left is fine, yes.

@bertfrees
Copy link
Member Author

I should note that the current implementation does it exactly the other way around.

@KariRudjord
Copy link

For NLB it's not importent to change it

@mixa72
Copy link

mixa72 commented Aug 18, 2015

My example reflects the default behaviour of our current formatter at SBS, but it doesn't bother if it's the other way round.

@dkager
Copy link
Contributor

dkager commented Aug 31, 2015

This behavior (slightly to the left) sounds OK to me.

@dkager
Copy link
Contributor

dkager commented Aug 31, 2015

Oh and in addition: it’s not important enough to change/fix. Yep I’m catching up slowly. ☺

@stesk
Copy link

stesk commented Aug 31, 2015

I agree that it's not that important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants