Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use liblouis 3.0.0 (incl. its nl-NL table) #50

Open
dkager opened this issue Aug 2, 2016 · 9 comments
Open

Use liblouis 3.0.0 (incl. its nl-NL table) #50

dkager opened this issue Aug 2, 2016 · 9 comments

Comments

@dkager
Copy link
Contributor

dkager commented Aug 2, 2016

@bertfrees Any hints?

@bertfrees
Copy link
Member

pipeline-mod-braille 1.9.15 uses liblouis 3.0.0-alpha, but not the new tables yet. So two things need to happen:

  • if 3.0.0-alpha won't do, update to 3.0.0 (this means publishing a new liblouis-nar and updating the liblouis-native module)
  • update the tables (this means copying them to the liblouis-tables module)

Is your table in mod-dedicon identical to the one in liblouis?

@dkager
Copy link
Contributor Author

dkager commented Aug 2, 2016

Is your table in mod-dedicon identical to the one in liblouis?

No, it is a backport to 2.6.5 and therefore avoids using some opcodes.

I'm assuming @egli has to publish the final 3.0.0 and then it can be included in pipeline-mod-braille. I think we can wait for that to happen. Presumably this also means moving the nl-NL table from mod-dedicon to the tables module.

@bertfrees
Copy link
Member

Ah yes. But the current table can safely be replaced by the new one in Liblouis 3.0.0?

Christian has already made the final 3.0.0 AFAIK.

We don't need to move anything to the tables module. We just update the liblouis-tables module to 3.0.0, and then remove the table from mod-dedicon and point to the new one from liblouis-tables instead.

@dkager
Copy link
Contributor Author

dkager commented Aug 2, 2016

But the current table can safely be replaced by the new one in Liblouis 3.0.0?

Yes. All we keep in mod-dedicon is the undefined character one-liner I think.

Christian has already made the final 3.0.0 AFAIK.

But not anything with liblouis-nar if I read your earlier comment correctly.

@bertfrees
Copy link
Member

I need to do that anyway because of the Mac binaries, Christian can't build those on his machine.

@bertfrees
Copy link
Member

@egli It seems that if you do a fresh checkout of liblouis v3.0.0, ./autogen.sh gives you an error because the m4 directory isn't there. You did something in commit liblouis/liblouis@60e5bf8. Maybe add a m4/.gitkeep file?

@bertfrees
Copy link
Member

Or just add a mkdir m4 to autogen.sh?

@bertfrees
Copy link
Member

Currently stuck on liblouis/liblouis-java@5542a87.

@egli
Copy link

egli commented Aug 3, 2016

Don't know if I ever removed the m4 directory. Will go for the m4/.gitkeep solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants