Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate EntityType #5

Open
glassjoseph opened this issue Jun 9, 2021 · 1 comment
Open

Validate EntityType #5

glassjoseph opened this issue Jun 9, 2021 · 1 comment
Labels

Comments

@glassjoseph
Copy link
Collaborator

We've had requests to validate allowed types of CPF and Resource.

On the one hand, it would be a straightforward safety check that could run on a schema save and warn editors in the Issues page. On the other hand, we should consider how much client-side validation the extension should handle, or if it is better to rely more on the API for error handling. If the latter, the API error handling on incorrect CPF entityType should be improved, as it currently returns an html xdebug warning. Warning: pg_execute(): Query failed: ERROR: null value in column "entity_type" violates not-null constraint

@deternitydx
Copy link
Member

Interesting. I think we should update the validation engine on the server to check for entity type, even if we do add that validation on the OpenRefine client side. I would like to stop any non-JSON error messages before they make it out to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants