Your code review!

[lee-sh-roy]

Pseudocode

Your pseudocode was very specific. I could definitely follow along.

Naming

Your variable and method names were clear and concise.

Overall Solution

You have a very clean solution! The refactor combined two cases into one with a clever use of ternary operation. I also liked your use of @solved, which also accounts for if the user continues to play (for whatever reason) and would correctly put @solved to false if that's the case.

Driver test code

You have good test coverage. The only thing is that in Ruby, using two '=' is preferable.

Reflection

I liked that you went online to learn more about symbols. It also seemed like you had a firm grasp of how to approach the problem.

[smileyface525]

Thank you, Roy!
I appreciate your detailed review.

eiko seino

On Apr 15, 2014, at 4:14 PM, "Roy Lee" [email protected] wrote:

Pseudocode

Your pseudocode was very specific. I could definitely follow along.

Naming

Your variable and method names were clear and concise.

Overall Solution

You have a very clean solution! The refactor combined two cases into one with a clever use of ternary operation. I also liked your use of @solved, which also accounts for if the user continues to play (for whatever reason) and would correctly put @solved to false if that's the case.

####Driver test code
You have good test coverage. The only thing is that in Ruby, using two '=' is preferable.

####Reflection
I liked that you went online to learn more about symbols. It also seemed like you had a firm grasp of how to approach the problem.

�
Reply to this email directly or view it on GitHub.