Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async race condition when compressing and renaming #48

Open
bogdanlupuro opened this issue Feb 18, 2016 · 2 comments
Open

Async race condition when compressing and renaming #48

bogdanlupuro opened this issue Feb 18, 2016 · 2 comments

Comments

@bogdanlupuro
Copy link

On the continue integration server I have a problem. I sometime get an error that it can't rename the zip artifact before deploying it to artifactory. I have isolated the problem to mvn:package task. The problem is that it starts packaging the folder but does not wait to finish before going to rename the function, so it is possible that the archive is not yet created. The rename should be called in the callback of the compress.tar and after that the async should be finished.

Or am I missing something?

@smh
Copy link
Owner

smh commented Feb 19, 2016

That sounds reasonable. The tests use small projects, so are unlikely to catch that. I would be very happy if you could provide a pull request fixing this.

@bogdanlupuro
Copy link
Author

Yeah, on my local computer I tried with very large projects (100mb) and couldn't reproduce. But on the integration server it happens random with very small ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants