Infinite Daemon restarting loop

[arturgontijo]

Today I've spotted this behavior and opened this #242 on Daemon's repo.
But it turned out that the problem is with the run_service.py of translation and text-summarization services.

@ferrouswheel could you please take a look on this?
I can fix it using the same logic that I've used on my services too.
Tell me what is better for you.

[arturgontijo]

Copying from my other services I've changed the run_service.pys:

https://github.com/arturgontijo/nlp-services/blob/snetd_inf_loop/translation/run_service.py
https://github.com/arturgontijo/nlp-services/blob/snetd_inf_loop/text-summarization/run_service.py

Tell me if is this ok? CircleCI is green BTW.

[ferrouswheel]

run_service was intentionally meant to restart the daemon and/or service if they crash. However leaving it to docker to do the restart seems like a better idea, as you've done, since docker has better restart strategies and backs off if it keeps failing.

…

On Fri, 5 Apr 2019, 7:17 AM Artur Gontijo, ***@***.***> wrote: Copying from my other services I've changed the run_service.pys: https://github.com/arturgontijo/nlp-services/blob/snetd_inf_loop/translation/run_service.py https://github.com/arturgontijo/nlp-services/blob/snetd_inf_loop/text-summarization/run_service.py Tell me if is this ok? CircleCI is green BTW. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#61 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAHWB2GeaTRT7KvDt-5pme-XIyYPTlk3ks5vdkGfgaJpZM4cc_px> .