Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attachment indicator broken color in dark mode #1932

Closed
dusansimic opened this issue Oct 12, 2022 · 4 comments · Fixed by #1933
Closed

Attachment indicator broken color in dark mode #1932

dusansimic opened this issue Oct 12, 2022 · 4 comments · Fixed by #1933
Assignees
Labels
hacktoberfest This issue is recommended for Hacktoberfest participants. website-bug Bug that is on the website itself

Comments

@dusansimic
Copy link
Collaborator

Screenshot from 2022-10-12 08-43-51

It should probably have a dark background so it would blend in a bit more.

@dusansimic dusansimic added hacktoberfest This issue is recommended for Hacktoberfest participants. website-bug Bug that is on the website itself labels Oct 12, 2022
@sfrunza13
Copy link
Contributor

Could I maybe give this a shot?

@sfrunza13
Copy link
Contributor

image
is the base 10 color in your dark-mode.css dark enough?

Should I also take a look at the name tag coloring? Or is this a part of a diff issue?
image

@dusansimic
Copy link
Collaborator Author

I'd prefer that variables from __fb-dark-mode selector are used. Those are the ones provided by the Messenger website. However, most of the times these kinds of problems are caused by some class having hardcoded light colors. I'd recommend instead using a solution done in #1931. You'll just need to find that class that is causing the issue.

Should I also take a look at the name tag coloring? Or is this a part of a diff issue?

There is no issue open for this so feel free to fix it too 😁.

@dusansimic dusansimic assigned dusansimic and sfrunza13 and unassigned dusansimic Oct 12, 2022
@dusansimic
Copy link
Collaborator Author

Also, add a todo comment like there is one in the pr i linked in my previous comment. That way we can know which css styles are our design and which are patches for Facebooks buggy website 😅.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest This issue is recommended for Hacktoberfest participants. website-bug Bug that is on the website itself
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants