Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace simple theme with startup theme #7

Closed
12 tasks done
GuySartorelli opened this issue Dec 3, 2024 · 3 comments
Closed
12 tasks done

Replace simple theme with startup theme #7

GuySartorelli opened this issue Dec 3, 2024 · 3 comments
Assignees

Comments

@GuySartorelli
Copy link
Member

GuySartorelli commented Dec 3, 2024

Pikachus have created https://github.com/silverstripeltd/startup-theme

silverstripe/startup-theme (this repository) was originally meant to house it.

This theme will become the new default theme for CMS 6, replacing the simple theme.

Acceptance Criteria

  • The code from https://github.com/silverstripeltd/startup-theme is dumped into here
    • Just do a force push, retaining all the commit history from the private repo. We don't need the existing commit history from this repo.
  • The steps for setting up a new GitHub repository are done for this repo
  • The theme gets a review from a "does this do what a default theme needs to do" pov
  • The theme gets a lightweight code quality review
  • The readme is updated if needed (ideally include a screenshot)
  • This repo is added to the supported modules docs list and supported modules repo
  • Module standardiser is run against this repo
  • This theme is added to installer
  • simple theme is removed from installer
  • Any docs referencing simple theme are updated to reference this repo instead for CMS 6 docs
  • simple theme is removed from the supported modules docs list and supported modules repo for CMS 6
  • Changelog explicitly calls out the change of theme and points out anything that people might need to be aware of

PRs

Kitchen sink CI run

@emteknetnz
Copy link
Member

Have merged PR, assigning back to do other steps

@GuySartorelli GuySartorelli removed their assignment Feb 3, 2025
@emteknetnz
Copy link
Member

@GuySartorelli I get the following issue when trying to create a sink/installer project

ERROR [User Notice]: File themes/startup/images/logo--silverstripe-cms.svg does not exist
IN GET /server-error
Line 84 in /var/www/vendor/silverstripe/framework/src/Control/SimpleResourceURLGenerator.php

@GuySartorelli
Copy link
Member Author

Looks like packagist was just slow to update - I got that locally as well, but after telling packagist to update and trying again the problem went away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants