Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group tree generation timeouts when you have a massive amount of groups #11577

Open
4 tasks done
beerbohmdo opened this issue Jan 24, 2025 · 4 comments
Open
4 tasks done

Comments

@beerbohmdo
Copy link
Contributor

beerbohmdo commented Jan 24, 2025

Description

In the getCMSFields function of Member there is a loop over all groups which create a tree like representation.

https://github.com/silverstripe/silverstripe-framework/blob/5/src/Security/Member.php#L1376

I program a sass platform which allowes the customers to create groups for their users. And now I am unable to open the Security section of the admin because of the function call above.

I don't know if the TreeDropdownField would be a better replacement or if that have similar issues.

Currently I cannot even disable the code by removing the DirectGroups field because the code directly runs inside the getCMSFields function.

Additional context or points of discussion

No response

Validations

  • You intend to implement the feature yourself
  • You have read the contributing guide
  • You strongly believe this feature should be in core, rather than being its own community module
  • You have checked for existing issues or pull requests related to this feature (and didn't find any)
@GuySartorelli
Copy link
Member

GuySartorelli commented Jan 27, 2025

Thanks for reporting - checking TreeDropdownField would definitely be the first thing I'd recommend trying. Would you like to investigate further and look at raising a PR to fix this?

@beerbohmdo
Copy link
Contributor Author

The TreeDropdownField is only for single values, thats maybe the reason why it not used here.

Currently it is a ListboxField. So a SearchableMultiDropdownField with a custom label should work. I will try that.

@GuySartorelli
Copy link
Member

There's an implementation of tree dropdorn that accepts multiple values. But yup searchable might work.

@beerbohmdo
Copy link
Contributor Author

I tried the Tree Field but it realy slow too and does not even load the subtree.

PR is open #11578

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants