Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation error doesn't surface on Title field #945

Closed
andrewandante opened this issue Nov 14, 2021 · 4 comments
Closed

Validation error doesn't surface on Title field #945

andrewandante opened this issue Nov 14, 2021 · 4 comments

Comments

@andrewandante
Copy link
Contributor

BaseElement combines Title and ShowTitle into one instance of TextCheckboxGroupField. If you require this field, and don't fill it out, the element will throw a Validation Error but not show you where - seems to be hidden by combining the fields.

@lerni
Copy link

lerni commented Jan 18, 2022

Just ran into this. If inline_editable is enabled, it even ignores the required field 😞 Setting a Title is essential for the use with dnadesign/silverstripe-elemental-virtual but ATM it looks like you cannot make Title a required field.

@michalkleiner
Copy link
Contributor

Increasing the impact to accommodate not being able to require the field when inline editable.

@GuySartorelli
Copy link
Member

@michalkleiner fyi the lack of validation for inline editable blocks is already raised separately in #699

@maxime-rainville
Copy link
Contributor

I don't see any scenario where we fix this without fixing #329

I'm going to call this one a duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants