Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: ProductImageExtension should use FitMax etc. to prevent upscaling #693

Open
wernerkrauss opened this issue Nov 21, 2018 · 1 comment
Open

Enhancement: ProductImageExtension should use FitMax etc. to prevent upscaling #693

wernerkrauss opened this issue Nov 21, 2018 · 1 comment

Comments

@wernerkrauss
Copy link
Contributor

The logic for preventing upscaling is now built in SS4.

ProductImageExtension::getImageAt() should should use FitMax, ScaleMaxWidth and ScaleMaxHeight.

This way all images are processed and resampled with the project's image quality settings
@wilr
Copy link
Contributor

wilr commented Nov 21, 2018

Thanks! PR welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wilr @wernerkrauss