Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fake columns #56

Open
nevrome opened this issue Mar 19, 2022 · 2 comments
Open

Fake columns #56

nevrome opened this issue Mar 19, 2022 · 2 comments

Comments

@nevrome
Copy link
Member

nevrome commented Mar 19, 2022

As discussed in #16 and on mattermost, there are a number of columns in various tables of Pandora, that only seem to serve as placeholders to be filled from other tables up- or downstream in the Pandora hierarchy. Imho they are pointless and confusing for data analysis.

I see three options how to address that:

  1. Do nothing and keep the fake columns around (as suggested by @ivelsko for the ethics columns)
  2. Populate them from the actual data columns in the other tables (as suggested by @trhermes)
  3. Delete them in the process of and behind get_df()

I don't like 1. for obvious reasons (and generally consider the ethics issue solved with the startup message). 2. is tricky to pull off and would force a lot of data download even if one only wants a single table. So 3. it is, in my opinion.

What do you folks say? (including @jfy133)

@trhermes
Copy link

trhermes commented Mar 20, 2022

What are the fake columns doing? I am also noticing now that pandora_tables() no longer works, giving: Error: attempt to apply non-function.

@nevrome
Copy link
Member Author

nevrome commented Mar 21, 2022

My understanding is this:

In the web interface Pandora has information that is displayed across different levels of the database hierarchy. So if something is Ethically dangerous, than this is displayed in different views and on multiple levels on the website, which is good.

In the database the information for that only really exists in TAB_Sample, though. So unfortunately the front-end sugar involves a nasty hack in the the database back-end: The respective columns do exist as well in the other tables relevant for displaying, but there they are empty (or weirdly filled). That's what I call a "fake column".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants