Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To figure: Add support for non text/binary file #24

Closed
shubhexists opened this issue Dec 17, 2023 · 0 comments · Fixed by #26
Closed

To figure: Add support for non text/binary file #24

shubhexists opened this issue Dec 17, 2023 · 0 comments · Fixed by #26
Assignees
@shubhexists
Labels
enhancement New feature or request priority:high High Priority Issue

Comments

@shubhexists
Copy link
Owner

Non UTF files are not supported currently.
There is a utility function in utils/read_files.rs that reads files by bytes.. But I fear that might break the commit function..
Hence, creating a separate branch to test and add it..
@shubhexists shubhexists self-assigned this Dec 17, 2023
@shubhexists shubhexists added enhancement New feature or request priority:high High Priority Issue labels Dec 17, 2023
@shubhexists shubhexists mentioned this issue Dec 18, 2023
Merged
@shubhexists shubhexists linked a pull request Dec 18, 2023 that will close this issue
Added support for binary(NonUTF8) files #26
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shubhexists shubhexists

Labels
enhancement New feature or request priority:high High Priority Issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added support for binary(NonUTF8) files shubhexists/vault
1 participant
@shubhexists