Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] IP whitelisting problem #1590

Open
1 task done
mdanilowicz opened this issue Jan 15, 2025 · 0 comments
Open
1 task done

[BUG] IP whitelisting problem #1590

mdanilowicz opened this issue Jan 15, 2025 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@mdanilowicz
Copy link
Collaborator

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Image

Currently, to whitelist an IP in maintenance mode, we need to handle two distinct IPs:

  1. Server IP: Represents where the frontends are hosted.
  2. Client IP: Represents the IP of the user sending the request.

Issues:

  • Whitelisting only the client IP: SSR will still serve the maintenance page, preventing navigation on the site.
  • Whitelisting only the server IP: All first calls will render the page, meaning the shop will be available only for the first call, then the CSR request will be blocked by the displaying maintenance mode

Expected Behavior

No response

Steps To Reproduce

No response

Environment

- OS:
- Node:
- pnpm:

Anything else?

No response

@mdanilowicz mdanilowicz added the bug Something isn't working label Jan 15, 2025
@BrocksiNet BrocksiNet moved this from No status to Developer Backlog in Composable Frontends Jan 16, 2025
@mdanilowicz mdanilowicz self-assigned this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Developer Backlog
Development

No branches or pull requests

1 participant