Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested tab groups broken in v2.19.1 #2320

Open
mathijssterk opened this issue Dec 20, 2024 · 3 comments
Open

Nested tab groups broken in v2.19.1 #2320

mathijssterk opened this issue Dec 20, 2024 · 3 comments
Labels
bug Things that aren't working right in the library. good first issue This bug or task is a good first issue for new contributors. help wanted Ready for a contributor to tackle.

Comments

@mathijssterk
Copy link

Since v2.19.1 nested tab groups no longer work. When clicking on the tab with the nested tab group, the top level tab group becomes empty and nothing is shown anymore.

Seems to be caused by #2299 as it still works fine in v2.19.0

Steps to reproduce the behavior:

  1. create a nested tab group
  2. try to navigate to one of the nested tabs

Demo

See this CodePen: https://codepen.io/mathijssterk/pen/qEWmbpN

Try to visit child tab B2. Good luck ;-)

@mathijssterk mathijssterk added the bug Things that aren't working right in the library. label Dec 20, 2024
@niboan
Copy link

niboan commented Jan 10, 2025

I have the same problem and did a little research myself before I found this issue. It seems that the nested tab group sets the active tab on the parent, but with the id of the nested tab.

Check the console in https://codepen.io/niboan/pen/gbYebpz

@claviska claviska added help wanted Ready for a contributor to tackle. good first issue This bug or task is a good first issue for new contributors. labels Jan 10, 2025
@bennymeier
Copy link

We also get errors with the tabs after updating to 2.19.1

@schilchSICKAG
Copy link
Contributor

schilchSICKAG commented Jan 31, 2025

As we might have caused this bug, we will fix it asap. Sorry, we seem to not have tested it with nesting when contributing it :(.

Handled via synergy-design-system/synergy-design-system#766, will create patches for Shoelace at the beginning of next week. Also adds some overall improvements for the tab handling and the underlying mutation observer, which may also caused other weird behavior so its a (small) win, too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Things that aren't working right in the library. good first issue This bug or task is a good first issue for new contributors. help wanted Ready for a contributor to tackle.
Projects
None yet
Development

No branches or pull requests

5 participants