Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete livestatus broker #7

Open
chaen opened this issue Dec 4, 2013 · 0 comments
Open

Incomplete livestatus broker #7

chaen opened this issue Dec 4, 2013 · 0 comments

Comments

@chaen
Copy link

chaen commented Dec 4, 2013

Hi,

While trying to do some benchmarks, I realized that the 'GET status' query of the livestatus module was returning wrong information (for example, always 0 for the service_checks_rate).

Looking at the code of shinken/modules/livestatus_broker/mapping.py I found this :

'requests': {
    'description': 'The number of requests to Livestatus since program start',
    'function': lambda item, req: 0,  # REPAIRME
    'datatype': int,
},
'requests_rate': {
    'description': 'The averaged number of request to Livestatus per second',
    'function': lambda item, req: 0,  # REPAIRME
    'datatype': float,
},
'service_checks': {
    'description': 'The number of completed service checks since program start',
    'function': lambda item, req: 0,  # REPAIRME
    'datatype': int,
},
'service_checks_rate': {
    'description': 'The averaged number of service checks per second',
    'function': lambda item, req: 0,  # REPAIRME
    'datatype': float,
},

So it perfectly explains why I always got 0 :D
However, I was wondering if this would be corrected anytime soon? service_checks and service_checks_rate are in my opinion among the most useful information you can get out of livestatus when doing a benchmark.

Thanks a lot!
Chris

Original ticket : shinken-solutions/shinken#963

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant