Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto advance debounce needs work #31

Open
sheepman4267 opened this issue Oct 25, 2024 · 1 comment
Open

Auto advance debounce needs work #31

sheepman4267 opened this issue Oct 25, 2024 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@sheepman4267
Copy link
Owner

As part of the development of our current auto advance system, code was added that keeps multiple auto advances at the same time from skipping over slides. It's better than nothing, but still broken.

  1. Using display.previous_slide.auto_advance_duration in checking elapsed time seems wrong. Take for example four slides, which have durations of 2, 3, 2, and 2 seconds. With the current code, slides one, two, and three are displayed, but slide three's auto advance is ignored. We should probably use display.current_slide.auto_advance_duration, but it seems to me that there must have been some reason for doing it this way. More thinking is needed.
  2. Even with this debounce code, we still sometimes have the same slide being triggered twice. This visually breaks transitions. We need to either debounce that event in _hyperscript, or debounce the view.
    Debouncing the view seems possible once we implement a redis backend, but maybe a _hyperscript solution is in order in the interim.
@sheepman4267 sheepman4267 added the bug Something isn't working label Oct 25, 2024
@sheepman4267 sheepman4267 added this to the Version 0.2.0 milestone Oct 25, 2024
@sheepman4267
Copy link
Owner Author

sheepman4267 commented Nov 13, 2024

Part 1 is sorted out: e90a4f0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant