From 72217dd975d981fac52320d42ccd41e028b8e20e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andr=C3=A9=20Luiz=20dos=20Santos?=
 <andre.netvision.com.br@gmail.com>
Date: Wed, 3 Nov 2021 17:23:28 -0300
Subject: [PATCH] createVideo does not wait for ffmpeg to finish

A script that loads a page and calls process.exit at the end, creates all the image files, but does not create the video file.

The problem is that stop() returns a Promise that is resolved before ffmpeg has had enough time to complete.
---
 index.js | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/index.js b/index.js
index 11c4ebb..510ad30 100644
--- a/index.js
+++ b/index.js
@@ -1,5 +1,6 @@
 const { FsHandler } = require('./handlers');
 const { exec } = require('child_process');
+const { promisify } = require('util');
 const PuppeteerMassScreenshots = require('puppeteer-mass-screenshots');
 
 class PuppeteerVideoRecorder {
@@ -24,7 +25,7 @@ class PuppeteerVideoRecorder {
     
     async stop () {
     	await this.screenshots.stop();
-    	return this.createVideo();
+    	await this.createVideo();
     }
 
     get defaultFFMpegCommand() {
@@ -39,13 +40,11 @@ class PuppeteerVideoRecorder {
         ].join(' ');
     }
 
-    createVideo(ffmpegCommand = '') {
+    async createVideo(ffmpegCommand = '') {
         const _ffmpegCommand = ffmpegCommand || this.defaultFFMpegCommand;
-        exec(_ffmpegCommand, (error, stdout, stderr) => {
-            if (error) throw new Error(error);
-            console.log(stdout);
-            console.log(stderr);
-        });
+        const { stdout, stderr } = await promisify(exec)(_ffmpegCommand);
+        console.log(stdout);
+        console.log(stderr);
     }
 }