Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: automatically reinstall when the reference has changed. #31

Open
tomek-he-him opened this issue Nov 17, 2014 · 3 comments
Open
Milestone

Comments

@tomek-he-him
Copy link
Collaborator

When you change a npm dependency's reference in package.json, it automatically gets uninstalled, and the new version gets downloaded and installed.

In napa you have to uninstall manually, take care of the cache (see my pull request), then reinstall. It would be über-cool if updating a napa dependency worked as seamlessly as updating an npm dependency.

@adius
Copy link

adius commented Feb 18, 2015

+1

@till
Copy link

till commented May 3, 2015

Just as a general thought as I am going through the code and the issue.

I am wondering if napa should wrap around npm libs instead. E.g. after code is downloaded, inject a package.json somewhere and then let the npm libs carry on with the rest. Seems like a lot of work is duplicated inside napa where code exists in npm.

@caseyWebb caseyWebb added this to the 3.0.0 milestone Oct 29, 2015
@caseyWebb caseyWebb self-assigned this Oct 29, 2015
@tschaub
Copy link
Contributor

tschaub commented Feb 8, 2016

I'm seeing what I think is this same issue. Here is an example test repo with two commits: https://github.com/tschaub/test-napa. The first and second commits refer to different git URLs for a napa dependency. If you check out the first commit, npm install, and then check out the second commit, npm install doesn't update the dependency as expected.

@tomekwi was #43 supposed to address this?

@caseyWebb caseyWebb removed their assignment Mar 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants