Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fontawesome / use only lit-fontawesome #88

Open
GildasMorel opened this issue Oct 2, 2020 · 4 comments · Fixed by #94
Open

Remove fontawesome / use only lit-fontawesome #88

GildasMorel opened this issue Oct 2, 2020 · 4 comments · Fixed by #94
Assignees
Labels
enhancement New feature or request hacktoberfest
Milestone

Comments

@GildasMorel
Copy link
Collaborator

At this time, fontawesome and lit-fontawesome are used.
It's useless.
As soon as we use web-components for everything, we only need lit-awesome.
Removing fontawesome will reduce the package / project weight.

@GildasMorel GildasMorel added this to the 0.5 milestone Oct 2, 2020
@GildasMorel GildasMorel self-assigned this Oct 2, 2020
@GildasMorel GildasMorel added enhancement New feature or request hacktoberfest labels Oct 2, 2020
@vivek32ta
Copy link

Hi @GildasMorel

I'd love to take this up.

Is it only the removing the package from node modules or does it also include refactoring of code where ever the packages are used?

Thanks and Regards,
Vivek

@GildasMorel
Copy link
Collaborator Author

Hi @vivek32ta ,

It includes refactoring some code into web components.
In fact, I'm fixing this issue right now because it's mandatory for version 0.5.
I won't need help on this one, but I'm gonna add more hacktoberfest issues some keep an eye on the project.

Thanks for proposing your help,

Gildas.

@vivek32ta
Copy link

I really appreciate the clear response. Thanks @GildasMorel

:)

@GildasMorel
Copy link
Collaborator Author

Waiting for issue #83 to be completed

GildasMorel added a commit that referenced this issue Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants