Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix zoom overflow #82

Open
GildasMorel opened this issue Sep 29, 2020 · 5 comments
Open

Fix zoom overflow #82

GildasMorel opened this issue Sep 29, 2020 · 5 comments
Assignees
@nicosh
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest
Milestone
0.5

Comments

@GildasMorel
Copy link
Collaborator

GildasMorel commented Sep 29, 2020 •
edited
Loading

  • Checkout the develop branch
  • Run npm i and npm start
  • Open Presenter view
  • Enable touch pointer plugin by using the "plugins" menu at top right of the screen
  • Click on the slide view to zoom

After zooming, the frame of the slide view goes beyond borders.
It needs to be fixed
@GildasMorel GildasMorel added bug Something isn't working good first issue Good for newcomers hacktoberfest labels Sep 29, 2020
@GildasMorel GildasMorel added this to the 0.5 milestone Sep 29, 2020
@nicosh
Copy link

nicosh commented Sep 30, 2020

If you want to assign me this issue i can work on this.

@GildasMorel
Copy link
Collaborator Author

Done !
Thx, tell me if you need anything.

@nicosh
Copy link

nicosh commented Sep 30, 2020

I have already forked the project i think change the css of #current is enough, its ok if i submit the PR later so is valid for hacktoberfest?

@GildasMorel
Copy link
Collaborator Author

Of course, it will be perfect.
Submit it tomorrow and it will count for it.

@nicosh nicosh mentioned this issue Sep 30, 2020
Merged
@GildasMorel
Copy link
Collaborator Author

Your PR has been merged, thanks a lot for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nicosh nicosh

Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
2 participants
@nicosh @GildasMorel