Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lit-element / granite-lit-bulma to last version #80

Open
GildasMorel opened this issue Sep 29, 2020 · 10 comments
Open

Update lit-element / granite-lit-bulma to last version #80

GildasMorel opened this issue Sep 29, 2020 · 10 comments
Assignees
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers hacktoberfest
Milestone

Comments

@GildasMorel
Copy link
Collaborator

GildasMorel commented Sep 29, 2020

  • Checkout the develop branch
  • Update lit-element and granite-lit-bulma dependencies to last version.
  • Run npm i and npm start and verify that there are no console errors.
@GildasMorel GildasMorel added good first issue Good for newcomers dependencies Pull requests that update a dependency file hacktoberfest labels Sep 29, 2020
@GildasMorel GildasMorel added this to the 0.5 milestone Sep 29, 2020
@karthikshetty03
Copy link

karthikshetty03 commented Sep 30, 2020

Can I work on this issue ?

@GildasMorel
Copy link
Collaborator Author

GildasMorel commented Sep 30, 2020

Of course, I assigned the issue to you, tell me if you need more informations.
I hope the description is clear enough.

Thanks for your help.

@karthikshetty03
Copy link

karthikshetty03 commented Sep 30, 2020

@GildasMorel what is the last version are you referring to ?

@GildasMorel
Copy link
Collaborator Author

I mean the last version of granite-lit-bulma (0.9.0-4) on
https://www.npmjs.com/package/@granite-elements/granite-lit-bulma.

I tried to put the version 0.9.0-4 in package.json and to update lit-element version to the last to, but I had some javascript errors at launch.
I didn't go further at the time.

@karthikshetty03
Copy link

karthikshetty03 commented Sep 30, 2020

Screenshot from 2020-10-01 01-41-04
I am getting the two warning errors on running npm start only for the first time after running npm i
Do they need to be fixed ?

@GildasMorel
Copy link
Collaborator Author

GildasMorel commented Sep 30, 2020

No, actually these two messages are just warnings.
The problem is when you open http://localhost:3000 in your browser and you get this :
tc-bulma-error

@GildasMorel
Copy link
Collaborator Author

Here is what I did :

  • update @granite-elements/granite-lit-bulma version to ^0.9.0-4
  • npm i
  • npm start
  • open my browser on localhost:3000.

This shows a blank page with the heading "TalkControl".
And you will see the error above.
That's what I would like to be fixed.

@karthikshetty03
Copy link

karthikshetty03 commented Oct 1, 2020

@GildasMorel Changing the import statements fixed these issues
I have created a PR #87

@GildasMorel
Copy link
Collaborator Author

Thanks a lot, I will review your PR by the end of the day.
I'll go back to you when it's done.

@GildasMorel
Copy link
Collaborator Author

Your PR has been merged, thanks a lot for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants